[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index][Thread Index][Top&Search][Original]

RE: lexical warnings upgrade

From: paul.marquess@bt.com
To: gsar@ActiveState.com, tchrist@perl.com, perl5-porters@perl.org
Date: Sun, 30 Jan 2000 00:10:16 -0000
Message-ID: <5104D4DBC598D211B5FE0000F8FE7EB202D49E4E@mbtlipnt02.btlabs.bt.co.uk>

I've had a closer look at the list of core library files that make use of
$^W and I've included a patch to make some of them use lexical warnings
instead.

These are the ones I changed (I don't think any of these are a parallel
existence on CPAN).

    lib/Cwd.pm
    lib/English.pm
    lib/ExtUtils/MM_Unix.pm
    lib/ExtUtils/Manifest.pm
    lib/Fatal.pm
    lib/File/Glob.pm
    lib/Math/BigFloat.pm
    lib/Text/ParseWords.pm
    lib/utf8_heavy.pl

These are on CPAN so I didn't touch them

    lib/CGI/Carp.pm
    lib/CGI.pm
    lib/CPAN/FirstTime.pm
    lib/CPAN.pm
    lib/IO/Select.pm

These use $^W to see if warnings were enabled and to display a warning
message themselves. More about this at the end.

    lib/Class/Struct.pm
    lib/Exporter/Heavy.pm
    lib/Socket.pm
    lib/Tie/Handle.pm
    lib/Tie/Hash.pm
    lib/Tie/Scalar.pm
    lib/fields.pm
    lib/syslog.pl
    lib/vars.pm                             

For example this is 

  carp "WARNING: calling ${pkg}->new since ${pkg}->TIESCALAR is missing"
        if $^W;  
  
I didn't have time to check whether these were controlling warnings from
a distance so I've left well alone

    lib/DB.pm
    lib/Dumpvalue.pm
    lib/Test.pm
    lib/diagnostics.pm
    lib/dumpvar.pl
    lib/perl5db.pl

These actually enable $^W. Anyone know why?

    lib/ExtUtils/MM_Win32.pm
    lib/ExtUtils/MakeMaker.pm
    lib/File/Spec/Win32.pm
    lib/I18N/Collate.pm

Back to the modules that use $^W to determine whether to print a
module-specific warning. The idiom

    warn "that isn't quite right" if $^W

won't work if a lexical warnings are enabled in the scope that has called
the module. What is needed is a way for a module to determine what the
warnings settings are at the point it was called.

Paul

begin 664 lex.gz
M'XL("#IXDS@"`VQE>`#=6'MSV[@1_UO^%!N+#25'XIN41=6-7=>YR4V=>O*X
M3"=.-+0(B:SY"@E:5C/^[EV`I$12C\GU;M*;<BB1Q#X`[/X6V$47WGM^!G@[
MD#ATYL$\3B$A:6!*BF).+1UH#'GB.I2`3]E'G2A%9'G4!;S?Q^`D2;`"RO1Q
M538VOWM_=0.J#9>>ZZ=,FGH$LCA/9P2PA<QHG*ZDBE&SX6T><1Z1:^-Z1$C2
M>)$Z(2Q]ZM4Z@+D?$'!P^%&24]2">E[/817GX,80Q10\YZ&I:L`FP>53"O&\
MZ"IT[DG5DS.[=Q8$%5'/H5S5S(E@3GAW:1QRB<LX3%+BD2CS4?\-&@0NTIG'
M/MX0NHS3>S9WC]+$EN7E<BDQFTFS.)0O;R[>R$Y.O3C-Y)]CSXFFOZ!6)\KD
M]2B&C])*HDXJ+?[-)E38P[F+4?N'MW\?@/@H0N;%>>#"'0$-T&&>O_!(6EA@
MAR>XX>*<<DUY1MC,ZU;Y;9[:ZZ1M]^`%5Y'+^K])B1/>(0-K/"I(-WRPB#4'
M81@$\3(KJ*X_G\-PAEW5L"<'_IU\N72E)!2;%(;*.O7H=>221QND6N/1R<E)
MHZ%S'4?P,_H:=%`M6QW9N@*:HBA'P^&PR?D.D<$XM3&H8]O4;=4L.$^:%^]#
MU]6!KH^`-P`\X0_O;T?/@%U!/',"$+Y\A#-0)ITNFBOS%U%((IH!3?W%@J0@
M9OE=BN[S(P(I<<D<7UP1EDX:^=&B4,@N?PX]X<L_@'P%\9?K=V(?NX'U=3);
MNIW.&=P^GSZ$V12_)GQJU0#Q?;@]P"BN^LE^_/#V^_TJ6@1^YAWP?8VCZ?\-
MH8:!36,;![JM66T<U+A;6!C9RO@`%D8#0Z^0@/?9+*?L[5D+!P6U"S^E3N3.
M'8RR%(0W%]=7X(=)G#(9M'GY@5;D;N2Z2R<V=-==^&LU'_#`(_U`_2"3KZ^G
M'R+_\9`K=K"V?++-<80+1$J^V@"JI*(+ZL[:YFYY35-M1=_RV@ZQFOLTQ59.
M,>[WNT\;F?H`_\:5"SL=8<H>#+]/$[@5!(U]/DW0ZAWN4@3\QW[ETXZ0DBP/
M*'Z3!T9C_WU.80Z"XTN^J+.-BU%`Y`PBKI\@X(:5$;:@VB"<'[-8$LY;.H]S
M-.G\&/(H(%D&92!"R5`$^V8*)5(.3J&%G/_Q^+\'BT[DSTE&OPN,-=Y]:-RP
M[(3?AOSK\%>3:P(018U#`#0'NEI;/[KPEC@!;O6S.`YPNWTL4I37P<H!NX\,
MI2E[:UM>QM'<7WQSIX$?W3_UM_>A2;DDGP01L,5XEDRJ38'CAX]@L\K\?B-H
M86W/&/9CX!5F#<$!OZ_I35]7S37_5DWMG<"TC7';IVO>EA\-6]?V^U%5S8&J
MK3T)E0$RW%)G%,24S#-Q@L;%-,QYB'T7TS(G$BG/W1A3M(">)$E]EETYD*W"
M.[0^2@$VKA4*L]@E5:P>EYDM1N+]8L(573II,BFXCON3M9CKDRH\GY5-K:4,
MH#&T=YOM?Q['FQ2@,9B3;P)N+$\HSSNLNGOBCF7VK&Q28NL/;Y,Z7G]W@^R'
M^37NV?)?_<6K('8.+7-;?$W8M\DU^+=)WY,8;\DTPP&70]7:'PXC8W"J5,'`
MTH]Y%*<A?(-NKW!L'VU(<]QAYE$>3K'MJ('+*8/E^;0R82;?9B]D>3&!PU>7
MPR:!I>=C<9LA&,B^K%PP`/,E$$RLN+`L@1#K+0H!6?C4#[$TQ@402S&^?S%'
MUQ)>^4OOTXOAYY?]WJU[@G\2?_9?]CY=D<\%Z=9]@0V"#,^?P[&@"<8Q('+$
M,C_N/&?&Z/4$%5XB62T8;#A^P=_Z`R09E<!+$*QA0*(%];"UCVR"U5_C^`E(
M@!@O\L7"Z&6T_1&,WJHT_L],OC^BWY-'*M^P].ACG+K9@9C>P=F,ZFV&6EQO
M$W=$MMJ.[!U2K=C6;?U`R6.,!Z992UD8TG@NR/9_4IB["Q\)+/T@8!ZEF!BQ
MM9Q[MES8L]WY=&GC<-437!+X(2(J'8!P3TB"#Z:_B5'&^#6/*4$J?[KXDD?K
M5ZX$GTN<Z0#.$Y_,2-8O$N=B'IO$Y[^?QW8Y]D,FL1^`.9V?3CWB/*RD)-B'
MO293$W8-6@UQC?8VV#1;,=M@:PJT<#:V#>5`:7TZ,(QZ0L5/&[!*IV5,ARLX
MIV&"MLR2P*>X2L@A-S!R3$J&/V6$1)OBK5Z/=P0,A!13BS/X5XP%C2@.8)&2
M!.0OG[XHP[$SG%\,7WV6![R70H+IKO%795;&2VOPR",(#OSY["_%ZUV9"!4S
MJ:5!OVTF6S7<CYA'XZ!O<ZA7.^J[8*>/^\[[NO`WUO9`TLQ'U)27#:JD%#0"
M"Q*1%%_<BE9'B\[0HI4)>!=^6O/>K3;*UN>MH$F<[2V9Y1C0Z]-.GV3(]D^2
M(>VA/.8,R`,))$\$S;)4&!O66+4,4P-=5RRF(P&Q?BRI*LK80K:Q.C+-L0D*
M-AB&L6&LGV/IUE@K>4]Q%MN\NTY<5&5D*4HA9AGCT2&Q>G&L8KX]*L1&BK)#
M;%-/&9IAEAV<CK1MSNV4=&R<EC,9:2-K6V+7EF>9AEK*&.J.V;=6*=,X+0<U
M&F$>P]@MRV@`KPVQ&OH:T+SW*7R:I80A9#^./I?09.*7'IG=9WEH(\4"R\"Z
0T-(4'#]G^0_4;?K`5!D`````
`
end

Follow-Ups from:: Graham Barr <gbarr@pobox.com>
Tom Christiansen <tchrist@chthon.perl.com>

[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index][Thread Index][Top&Search][Original]