[PATCH 5.005_63] h2xs goof and a depessimization

[Ilya Zakharevich <ilya@math.ohio-state.edu>]

The first chunk is a bugfix (needed if there is exactly one constant
to export), the other one removes unnecessary errno assignments.

Now can someone remind me why constant() communicates failure via $!
instead of doing it via, say, an extra argument?

Ilya

--- ./utils/h2xs.PL~	Fri Oct  1 18:58:16 1999
+++ ./utils/h2xs.PL	Wed Jan 19 15:00:31 2000
@@ -956,6 +956,7 @@ END
 static double
 constant(char *name, int len, int arg)
 {
+    errno = 0;
     if (strEQ(name + $offarg, "$list->[0]")) {	/* $pref removed */
 #ifdef $pref$list->[0]
 	return $protect$pref$list->[0];
@@ -994,6 +995,9 @@ END
 static double
 constant$npref(char *name, int len, int arg)
 {
+END
+
+  print $fh <<"END" if $npref eq '';
     errno = 0;
 END

---

[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index][Thread Index][Top&Search][Original]

---