Re: MakeMaker WriteMakefile isn't just MM->new

[andreas.koenig@anima.de (Andreas J. Koenig)]

>>>>> On 03 Jan 2000 10:21:54 +0100, andreas.koenig@anima.de (Andreas J. Koenig) said:

>>>>> On 02 Nov 1999 12:57:01 +0100, andreas.koenig@anima.de (Andreas J. Koenig) said:

>> One could even throw out the Version_check and save more than the time
>> that $Setup_done was designed to save.

 > I'll issue a separate patch for that one.

Here it is.
Cheers,
-- 
andreas

--- perl5.005_63..4751/lib/ExtUtils/MakeMaker.pm~63~4751	Tue Jan  4 09:24:52 2000
+++ perl5.005_63..4751/lib/ExtUtils/MakeMaker.pm	Tue Jan  4 09:29:02 2000
@@ -91,19 +91,11 @@ if ($Is_Cygwin) {
     require ExtUtils::MM_Cygwin;
 }
 
-# The SelfLoader would bring a lot of overhead for MakeMaker, because
-# we know for sure we will use most of the autoloaded functions once
-# we have to use one of them. So we write our own loader
-
 full_setup();
 
-# The only subroutine we do not SelfLoad is Version_Check because it's
-# called so often. Loading this minimum still requires 1.2 secs on my
-# Indy :-(
-
-# 3 years later we can say, Version_check takes 0.2 secs on my Linux
-# and MakeMaker has become so stable that we could drop the use of
-# Version_check altogether
+# The use of the Version_check target has been dropped between perl
+# 5.5.63 and 5.5.64. We must keep the subroutine for a while so that
+# old Makefiles can satisfy the Version_check target.
 
 sub Version_check {
     my($checkversion) = @_;
--- perl5.005_63..4751/lib/ExtUtils/MM_Unix.pm~63~4751	Tue Jan  4 09:17:40 2000
+++ perl5.005_63..4751/lib/ExtUtils/MM_Unix.pm	Tue Jan  4 09:23:39 2000
@@ -3611,12 +3611,6 @@ config :: $(INST_AUTODIR)/.exists
 	'.$self->{NOECHO}.'$(NOOP)
 ';
 
-    push @m, qq{
-config :: Version_check
-	$self->{NOECHO}\$(NOOP)
-
-} unless $self->{PARENT} or ($self->{PERL_SRC} && $self->{INSTALLDIRS} eq "perl") or $self->{NO_VC};
-
     push @m, $self->dir_target(qw[$(INST_AUTODIR) $(INST_LIBDIR) $(INST_ARCHAUTODIR)]);
 
     if (%{$self->{HTMLLIBPODS}}) {
--- perl5.005_63..4751/lib/ExtUtils/MM_VMS.pm~63~4751	Tue Jan  4 09:17:40 2000
+++ perl5.005_63..4751/lib/ExtUtils/MM_VMS.pm	Tue Jan  4 09:23:10 2000
@@ -1106,13 +1106,6 @@ config :: $(INST_AUTODIR).exists
 	$(NOECHO) $(NOOP)
 ';
 
-    push @m, q{
-config :: Version_check
-	$(NOECHO) $(NOOP)
-
-} unless $self->{PARENT} or ($self->{PERL_SRC} && $self->{INSTALLDIRS} eq "perl") or $self->{NO_VC};
-
-
     push @m, $self->dir_target(qw[$(INST_AUTODIR) $(INST_LIBDIR) $(INST_ARCHAUTODIR)]);
     if (%{$self->{MAN1PODS}}) {
 	push @m, q[
--- perl5.005_63..4751/lib/ExtUtils/MM_Win32.pm~63~4751	Tue Jan  4 09:17:40 2000
+++ perl5.005_63..4751/lib/ExtUtils/MM_Win32.pm	Tue Jan  4 09:24:34 2000
@@ -749,12 +749,6 @@ config :: $(INST_AUTODIR)\.exists
 	'.$self->{NOECHO}.'$(NOOP)
 ';
 
-    push @m, qq{
-config :: Version_check
-	$self->{NOECHO}\$(NOOP)
-
-} unless $self->{PARENT} or ($self->{PERL_SRC} && $self->{INSTALLDIRS} eq "perl") or $self->{NO_VC};
-
     push @m, $self->dir_target(qw[$(INST_AUTODIR) $(INST_LIBDIR) $(INST_ARCHAUTODIR)]);
 
     if (%{$self->{HTMLLIBPODS}}) {



END_OF_PATCH

---

References to:

andreas.koenig@anima.de (Andreas J. Koenig)

---

[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index][Thread Index][Top&Search][Original]

---